Trac30220 use conditional on LO bookmarks #382
+80
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detected by openjdk version "11.0.15".
The WollMux command 'setGroups' is changed in a conditional on the bookmark. Also we rename the bookmark, so that WollMux doesn't care about it.
This was referenced Dec 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased branch with one commit 2 years ago from Daniel Sikeler.
In contrast to #381 this one inserts conditions on bookmarks in the document.
The difference is that with this PR:
while with PR 381:
Now i don't know for sure which one of these is the "real" scenario that reflects actual usage, but i suspect it's the SibaLesSer.ott one, and the trac30220_bookmarkVisibility.odt was just created for easier testing with unmodified WollMux.
(plus the same javadoc fixes as in the other PR)