Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODE #channel does not send 329 RPL_CHANNELCREATED #130

Closed
slingamn opened this issue Jun 9, 2024 · 7 comments
Closed

MODE #channel does not send 329 RPL_CHANNELCREATED #130

slingamn opened this issue Jun 9, 2024 · 7 comments

Comments

@slingamn
Copy link

slingamn commented Jun 9, 2024

In response to a successful MODE #channel (i.e. list channel modes), Sable sends 324 RPL_CHANNELMODEIS but not 329 RPL_CHANNELCREATED (also referred to as RPL_CREATIONTIME):

https://modern.ircdocs.horse/#rplcreationtime-329

This numeric is not in either of the RFCs. It seems to have been introduced by Bahamut and become a de facto standard, as per https://www.alien.net.au/irc/irc2numerics.html

@progval
Copy link
Contributor

progval commented Jun 9, 2024

spec says "Servers MAY also return the RPL_CREATIONTIME (329) numeric following RPL_CHANNELMODEIS."

If Sable is the only server not to do it, then could you amend the spec to SHOULD, and add an irctest for that?

@DasBrain
Copy link

DasBrain commented Jun 9, 2024

Channel created makes only sense for networks that store the channel timestamp somewhere.
So... All IRC networks except IRCnet (they did reject the TS approach) and maybe a few others.

@slingamn
Copy link
Author

slingamn commented Jun 9, 2024

Right, irc2 doesn't send it either.

@slingamn
Copy link
Author

slingamn commented Jun 9, 2024

MAY actually seems correct here, because is this numeric even useful to clients?

@slingamn slingamn closed this as completed Jun 9, 2024
@TheDaemoness
Copy link
Member

Kinda, yes. At least one client (glirc) processes it to show it to users as part of information about a channel.

@DasBrain
Copy link

DasBrain commented Jun 9, 2024

Both hexchat and weechat display it to users as well:

Here the response when the user enters /mode in a channel:

Hexchat:

* Channel #libera modes: +CPTntf #libera-overflow
* Channel #libera created on Fri Apr 23 23:05:33 2021

Weechat:

17:55 -- Mode #libera [+CPTntf #libera-overflow]
17:55 -- Channel created on Fri, 23 Apr 2021 23:05:33

@slingamn
Copy link
Author

slingamn commented Jun 9, 2024

Makes sense, I opened a PR here: ircdocs/modern-irc#238

I agree with Val's implicit recommendation that Sable specifically doesn't need to send it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants