Create a sample 17 Observables with redux-observables & ReactiveX.js #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxonrails
changed the title
brauliodiez
reviewed
Dec 21, 2016
|
|
||
| export const ColorDisplayer = (props: Props) => { | ||
| // `rgb(${props.color.red},${props.color.green}, ${props.color.blue}) })` | ||
| // "rgb(" + props.color.red + ", 40, 80)" |
There was a problem hiding this comment.
Should we remove this commented code?
brauliodiez
reviewed
Dec 21, 2016
| action$.ofType(actionsEnums.MEMBER_REQUEST_STARTED).mergeMap(action => | ||
| memberAPI.getAllMembers() | ||
| // Asynchronously wait 2000ms then continue | ||
| .delay(2000) |
There was a problem hiding this comment.
Nice, we could add as well another source via websockets (I think in the link you provided there was once against stock exchange value not sure if public)
brauliodiez
reviewed
Dec 21, 2016
| @@ -0,0 +1,13 @@ | |||
| import * as React from "react"; | |||
|
|
|||
| export const NameEditComponent = (props: {userName: string, onChange: (name: string) => any}) => { | |||
There was a problem hiding this comment.
I would remove all the components that are not related with the sample itself, just to get thing simpler, I would keep only the member list components, actions, reducers, what do you think?
There was a problem hiding this comment.
Yes, it's better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redux-observable.js.org/
http://reactivex.io/