Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Example of resolveTransaction on hw-app-eth/README.md incorrect #788

Open
playmint-jbr opened this issue Feb 2, 2022 · 1 comment
Open

Example of resolveTransaction on hw-app-eth/README.md incorrect #788

playmint-jbr opened this issue Feb 2, 2022 · 1 comment

Comments

@playmint-jbr
Copy link

The example of how to use resolveTransaction on https://github.com/LedgerHQ/ledgerjs/blob/master/packages/hw-app-eth/README.md just passes the unsigned tx, but the real function has 3 args.
@bkbooth
Copy link

bkbooth commented Feb 22, 2022

Yep, hw-app-eth is now showing a deprecation warning about not providing a resolution to signTransaction, but the example given in the docs doesn't work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkbooth @playmint-jbr