Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignerV2 interface is confusing #90

Open
samlaf opened this issue Dec 21, 2023 · 1 comment
Open

SignerV2 interface is confusing #90

samlaf opened this issue Dec 21, 2023 · 1 comment
Assignees

Comments

@samlaf
Copy link
Collaborator

samlaf commented Dec 21, 2023

The functions in the signerv2 (for eg this) return bind.SignerFn instead of SignerFn, which is confusing because the txMgr needs a SignerFn. So the user either has to wrap the bind.SignerFn themselves, or use the more complicated (and also confusing) signerFromConfig. This one is confusing because forcing user to use the config which has too many fields and unclear which ones are mandatory and which ones are not.

I think we should just make the simple constructors return SignerFn directly, and then the SignerFromConfig can just call those and return directly, instead of wrapping their returned bind.SignerFn in a SignerFn.

@samlaf
Copy link
Collaborator Author

samlaf commented Apr 10, 2024

@shrimalmadhur what's the state of this? Also why do we still have signer around? Is that just for backwards compatibility? Is it still relevant to anything/anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants