Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names collision #156

Open
sanguinariojoe opened this issue Nov 8, 2022 · 2 comments
Open

Names collision #156

sanguinariojoe opened this issue Nov 8, 2022 · 2 comments
Assignees

Comments

@sanguinariojoe
Copy link

sanguinariojoe commented Nov 8, 2022

Hey guys!

This is somehow related with #154. You have a folders structure/naming problem. To explain that, let's consider lib/linalg/BasisWriter.h:16:

#include "utils/Database.h"

Since you are using quotes, the compiler is first looking for Database.h on lib/linalg/utils/. When that fails (because such folder does not exist), it start looking all around the include paths. Of course, the probabilities of having some other library with a utils/Database.h header file are large.

That names collision would be a problem while compiling the library, which might be eventually fixed by the user (if he really knows what he is doing). But of course that is unacceptable when installing the library.

The easiest solution is renaming the lib/ folder as libROM/, and replacing those includes (where the relative path is not working) by something like #include "libROM/utils/Database.h". It is still not a perfect solution, since collisions might yet happens with the installed library itself, but it is much safer.

Otherwise, you need to rethink the folders structure, so just subfolders are considered

@chldkdtn
Copy link
Collaborator

chldkdtn commented Nov 8, 2022

@pranav-vempati can you look into this issue?

@sanguinariojoe
Copy link
Author

For the time being, I made a workaround in the CMake installation, so at least things can be compiled against the installed library (unless there are name collisions, that will be though). When this is fixed I will revert that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants