Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper error handling in RMQ DB. #34

Closed
koparasy opened this issue Dec 7, 2023 · 2 comments
Closed

Proper error handling in RMQ DB. #34

koparasy opened this issue Dec 7, 2023 · 2 comments
Assignees
@lpottier
Milestone
AMS Workflow sche...

Comments

@koparasy
Copy link
Member

koparasy commented Dec 7, 2023

Currently when errors happen in the AMS lib RMQ database we tend to completely fail. We need to reliably continue execution and re-establish the connection.

This should become after #30 is merged in.
@koparasy koparasy added this to the AMS Workflow scheduler milestone Dec 7, 2023
lpottier added a commit that referenced this issue Feb 12, 2024
@lpottier
Added fault-tolerance features to RMQ broker (#34).
23429ea 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Feb 12, 2024
@lpottier
Added fault-tolerance features to RMQ broker (#34).
ff267b3 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Feb 12, 2024
@lpottier
Added fault-tolerance features to RMQ broker (#34).
d9a31a7 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Feb 12, 2024
@lpottier
Added fault-tolerance features to RMQ broker (#34).
68cfa91 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Feb 12, 2024
@lpottier
Added fault-tolerance features to RMQ broker (#34).
4b62eb5 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
lpottier added a commit that referenced this issue Feb 12, 2024
@lpottier
Added fault-tolerance features to RMQ broker (#34).
25156c9 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
koparasy pushed a commit that referenced this issue Feb 14, 2024
@lpottier @koparasy
Added fault-tolerance features to RMQ broker (#34).
7d92b65 
- Broker will restart if underlying connection is faulty

- Broker will send unacknowledged from previous connection (this could result in messages being received twice or more if errors happen with the wrong timing)

- Fixed a Static Initialization Order Fiasco (actually destruction fiasco) in ResourceManager and AMS DB

Signed-off-by: Loic Pottier <[email protected]>
@koparasy
Copy link
Member Author

Should we close this?

@lpottier
Copy link
Collaborator

Yes, I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpottier lpottier

Labels
None yet
Projects
None yet
Milestone
AMS Workflow scheduler
Development

No branches or pull requests
2 participants
@koparasy @lpottier