Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing context.set_hairline()? #226

Closed
dtromb opened this issue May 29, 2024 · 3 comments
Closed

Missing context.set_hairline()? #226

dtromb opened this issue May 29, 2024 · 3 comments

Comments

@dtromb
Copy link
Contributor

dtromb commented May 29, 2024

It seems like the function cairo_set_hairline(cairo_boot_t) (added in 1.18) is missing from the wrapper in context.py.

This function supports drawing wireframe or single pixel scale-independent lines, and is a very important feature to have when debugging graphics renders.

It should be relatively straightforward to add!

@liZe
Copy link
Member

liZe commented May 29, 2024

It should be relatively straightforward to add!

Yes. Interested in opening a PR?

@dtromb
Copy link
Contributor Author

dtromb commented May 30, 2024

Ok, will do!

The comments in the code have annotations as to which version of cairocffi newly added functions were released in, but this isn't targeted to a version. Just omit? Or... what version to put there? (FYI relevent to version target: will PR #81 if you like too since we need that functionality here and will implement regardless)

liZe added a commit that referenced this issue Jun 18, 2024
Added Context.{get,set}_hairline(), according changes to ffi header, …
@liZe
Copy link
Member

liZe commented Jun 18, 2024

Closed by #227.

@liZe liZe closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants