-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: No background in tooltips and menus #2713
Comments
This is fascinating. I suspect Windows 10 for some reason. I'll try my 11 machine and then see how I can boot up into 10. @dcl would you happen to have any OS settings in effect, like setting everything to "high contrast mode", by any chance? |
Oh you know what, I bet the background colors are failing because the platform OS for Windows 10, which would be used by Tauri, doesn't support OKLCH colors! I can try to replicate this on that route, turning off OKLCH color support and seeing if that does this. I think we need to provide fallback colors is all |
I don't have high contrast mode on, or afaict any other OS setting that should affect it. That said I suspect you're on to something with the color support, trying in dark mode introduces quite a lot more color issues than just the backgrounds: |
Bingo, because in light mode the colors are falling back to black but that's not that different from our text color and whatnot, but in dark mode the OKLCH-defined text colors are falling back from off-white to black, looking way more jarring. We need some backup colors. I just need to figure out how far back up, like are we talking OKLCH isn't supported (relatively recent) or CSS variables (which have been around for a minute and we rely pretty heavily on). I'll try to make fallback behavior for both |
Actually just one more question @dcl, could you provide me a version number of Edge that you're running? CSS Variables are supported all the way back to MS Edge v16 so I think I can get away with assuming a user has that, since WebRTC wasn't supported until v79 and it's a hard requirement for us. OKLCH wasn't supported until v111 so I think that's the culprit. |
Great question! It seems to be v44? I have literally never run Edge before, it might still be old Edge? |
That would make sense then that you still have old Edge, and the thing about Tauri (how we build the desktop app) is it defers to the OS about what browser it should use, so it uses Edge on Microsoft of course, even if you as the user set Firefox or Chrome as your default browser. If you don't mind, could you leave Edge in its old version for a bit? Once we get the PR I've made above in and release a new version, I'd love to see if you get solid backgrounds and better colors afterward. Although I don't know if you'll be able to use the WebRTC stream we use to connect to the engine so after you verify that you might want to upgrade your Edge to a newer version sorry 😅 |
No worries, I'll hold off until we get this resolved.
Weirdly enough it seems to work fine. I wonder if Tauri has a fallback implementation? |
Huh super weird I don't know! Neat that that part works though. We've just released v0.22.7 that includes a compatibility fallback color system to hsl that should work for you; do you mind updating to that version to see if it fixes your issue? You should see an updater popup if you open the app. |
Dang it! Sorry for the false hope. I've just gotta download an old version of Chrome so I can see it breaking and then being fixed with my own eyes. We'll get there, apologies for the delay. |
@dcl this should be fixed because since we have migrated to Electron from Tauri, we ship a nearly-isomorphic version of the Chrome browser to every platform with the app. If you install app v0.25.0+ I am confident this will be resolved. |
I'm closing, this seemed to be a Tauri specific issue. If it comes back we can address it again but others would be reporting the same issue across their systems today. Edit: Sorry, will re-open to at least include a regression test, which will simply check the settings background matches what's expected... |
Describe the bug
The background is missing in tooltips and and all other popovers, resulting in the content overlapping with whatever is underneath. The issue is appearing for me in both light and dark mode on the Windows client, but not in the browser.
Steps to Reproduce
Expected Behavior
The content in popovers is legible
Screenshots and Recordings
Desktop OS
Windows 10
Browser
No response
Version
0.22.2
Additional Context
No response
The text was updated successfully, but these errors were encountered: