Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Samples to Modeling App #1350

Open
jgomez720 opened this issue Feb 6, 2024 · 3 comments · May be fixed by #3912
Open

Add Samples to Modeling App #1350

jgomez720 opened this issue Feb 6, 2024 · 3 comments · May be fixed by #3912
Assignees
@jgomez720
Labels
enhancement New feature or request
Milestone
v1 Modeling App L...

Comments

@jgomez720
Copy link
Collaborator

jgomez720 commented Feb 6, 2024 •
edited
Loading

This would give users a button in which they can access our sample KCL files (pulls directly from kcl-samples repo). When user selects the option, they get prompted with "Are you sure you want to import the sample code? This will overwrite the code you currently have"

Screenshot 2024-02-06 at 12 02 00 PM
@jgomez720 jgomez720 self-assigned this Feb 6, 2024
@jgomez720
Copy link
Collaborator Author

jgomez720 commented Feb 6, 2024 •
edited
Loading

Having a direct import of the code would be great for the future, but I am fine settling with a link in the three-dot menu for now:
#1352

@github-actions github-actions bot mentioned this issue Feb 12, 2024
Merged
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Feb 13, 2024
@jessfraz jessfraz added the enhancement New feature or request label Jun 22, 2024
@franknoirot
Copy link
Collaborator

Yes, I think we could add an Import example command with the following arguments:

  1. method: will be new file by default on desktop and can only be overwrite on web
  2. example: will have a list of all the KCL samples from the repo as options. Will be used to fetch the actual code when executed

We'll hook up a confirmation dialog if the method is overwrite

@jgomez720
Copy link
Collaborator Author

Yeah this would be sick!

@franknoirot franknoirot linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgomez720 jgomez720

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1 Modeling App Launch
Development

Successfully merging a pull request may close this issue.

Add ability to open KCL samples in-app KittyCAD/modeling-app
3 participants
@jessfraz @franknoirot @jgomez720