Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a need to make the class AbstractColumn internal? #138

Open
YokiToki opened this issue Oct 2, 2019 · 3 comments
Open

Is there a need to make the class AbstractColumn internal? #138

YokiToki opened this issue Oct 2, 2019 · 3 comments

Comments

@YokiToki
Copy link

YokiToki commented Oct 2, 2019

Or maybe there is another way to create a custom column (e.g postgreSQL geography point)? I can create extension function of TableBuilder but can't access to ColumnBuilder and AbstractColumn from another package.

@KenjiOhtsuka
Copy link
Owner

I thought that a good library doesn't force users to think about the internal structure, so I made most classes internal.

You are saying https://www.postgresql.org/docs/9.4/datatype-geometric.html , right?

I have to add those types of columns...
Or, if you have code for those columns and give me the Pull Request, I can review and merge.

@KenjiOhtsuka
Copy link
Owner

But I know it is a debatable point, because it could be very flexible if users can customize.

@YokiToki
Copy link
Author

YokiToki commented Oct 2, 2019

Sorry, I mean https://postgis.net/workshops/postgis-intro/geography.html but I think it is not necessary to add those types to the library, it would be good to have them separate extension if we talk specifically about PostGIS.

@YokiToki YokiToki changed the title Is there a need to make the class AbstractColumn internal? Is there a need to make the class AbstractColumn internal? Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants