Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NetworkOptions.ca_roots_path() #41

Open
mkitti opened this issue Jan 3, 2022 · 0 comments · May be fixed by #47
Open

Use NetworkOptions.ca_roots_path() #41

mkitti opened this issue Jan 3, 2022 · 0 comments · May be fixed by #47

Comments

@mkitti
Copy link

mkitti commented Jan 3, 2022

Currently, the location of the certificate roots file is hard coded:

Git.jl/src/git_function.jl

Line 33 in a7fd3e9

ssl_cert = joinpath(dirname(Sys.BINDIR), "share", "julia", "cert.pem")

However, this should be determined by NetworkOptions.jl:
https://github.com/JuliaLang/NetworkOptions.jl#ca_roots_path

One reason for this is that the location of the certificate roots file should be able to be overriden by changing JULIA_SSL_CA_ROOTS_PATH.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NetworkOptions.ca_roots_path() to find certificates giordano/Git.jl
1 participant
@mkitti