Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed TaijaPLotting #111

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Jul 23, 2024

cc @Rockdeldiablo I've had to remove TaijaPlotting from the docs environment to be able to specify a compat entry for MLJBase that doesn't cause issues. I think the issue needs to be fixed on the TaijaPlotting side, which is a mess of a package right now. This should fix things here to get the new release out (but will lead to error when trying to use the new version with TaijaPlotting).

@pat-alt pat-alt linked an issue Jul 23, 2024 that may be closed by this pull request
@pat-alt pat-alt merged commit d27ee27 into main Jul 23, 2024
8 of 9 checks passed
@pasq-cat
Copy link
Contributor

@pat-alt so how do we proceed?

@pat-alt
Copy link
Member Author

pat-alt commented Jul 23, 2024

I'm trying to fix it: JuliaTrustworthyAI/TaijaPlotting.jl#26

But is this stopping you from continuing work on CP.jl? Otherwise I'll stop working on this now and focus on ICML again 😅

@pasq-cat
Copy link
Contributor

@pat-alt nono, i will use my local version. don't worry. i am stuck on a different thing now. pls focus on icml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compat for MLJBase still messing things up
2 participants