Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

473 generator add t crex #476

Merged
merged 28 commits into from
Sep 23, 2024
Merged

473 generator add t crex #476

merged 28 commits into from
Sep 23, 2024

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Sep 23, 2024

No description provided.

@pat-alt
completed point a
6c45099
@pat-alt
generic constructor for all models (will discard)
f1dfe22
@pat-alt
on to rule extraction
06b8809
@pat-alt
baby steps
accc569
@pat-alt
wow
4b919c9
@pat-alt
ok
f13c1e1
@pat-alt
accuracy and feasibility working
df28abf
@pat-alt
moving on to step (b) finally
9fc5ae7
@pat-alt
baby steps, but some rectangle still don't make sense
a06107b
@pat-alt
getting there
db912e6
@pat-alt
leggo
537091f
@pat-alt
progress on point c (grid)
4f466a1
@pat-alt
think this does it?
e468ad5
@pat-alt
point (d) is implemented but something is wrong with (c)
c299059
@pat-alt
turning back to (c)
df6375d
@pat-alt
all sorted, now turning to (e)
f4b975b
@pat-alt
(e) basically done too
a05f8fe
@pat-alt
almost there
35256fc
@pat-alt
just need to extract leaf rules
2573949
@pat-alt
done with (e)
eef2899
@pat-alt
works, just needs to be polished now
48bb71c
@pat-alt
fixed small issue with element type propagation
ee8b667
@pat-alt
starting on docs
d8cb967
@pat-alt
almost there
229eeeb
@pat-alt
getting this
0580719
@pat-alt
docs and tests added
98fdd2b
@pat-alt pat-alt linked an issue Sep 23, 2024 that may be closed by this pull request
[Generator] Add T-CREx #473
Closed
9 tasks
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.69027% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.08%. Comparing base (bab1a93) to head (bbe228c).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
ext/DecisionTreeExt/t_crex/tree.jl 83.92% 9 Missing ⚠️
ext/DecisionTreeExt/t_crex/utils.jl 97.88% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   90.61%   91.08%   +0.46%     
==========================================
  Files          85       90       +5     
  Lines        1695     1919     +224     
==========================================
+ Hits         1536     1748     +212     
- Misses        159      171      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-alt pat-alt merged commit d27f93b into main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Generator] Add T-CREx
1 participant
@pat-alt