Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat Helper Spams. #378

Open
mattBrzezinski opened this issue Aug 15, 2021 · 6 comments
Open

Compat Helper Spams. #378

mattBrzezinski opened this issue Aug 15, 2021 · 6 comments
Labels

Comments

@mattBrzezinski
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member

This "keep old compat" versus "drop old compat" business is more trouble than it's worth.

Let's just get rid of the "drop old compat" feature, and only do the "keep old compat" stuff.

This would technically be breaking, so we'll have to release CompatHelper 4.0.

I don't think very many people use the "drop old compat" feature, anyway. And if they do, they can use CompatHelper v2.

@DilumAluthge
Copy link
Member

If we always use the "keep old compat" codepath, then we can probably also do what you said on Slack:

Can we not just check if a PR title which contains the dependency and the version we are bumping to exists already? Instead of trying to match the title exactly?

@mattBrzezinski
Copy link
Member Author

mattBrzezinski commented Aug 15, 2021

Looking into why keep existing compat is being added in here. We can probably save this drop features part by spending some more time looking at it.

https://github.com/davidanthoff/PyRhodium.jl/pulls

Screen Shot 2021-08-14 at 8 26 12 PM

@mattBrzezinski
Copy link
Member Author

I cannot understand why the above two PRs;

Were created. By default we are passing in KeepEntry as the action. When we call pr_title_parenthical we should always be appending ", (keep existing compat)". For some reason we're not? The workflow for this repo isn't overriding it either?

😕

@mattBrzezinski
Copy link
Member Author

All of the PRs created for:

Were most likely using v3.0.0 which we have seemingly resolved. Nothing new will be created in those repos, and looking at all of their existing actions, they seem to run hourly and have been fine since picking up the patched version of CompatHelper.

@DilumAluthge
Copy link
Member

I cannot understand why the above two PRs;

Were created. By default we are passing in KeepEntry as the action. When we call pr_title_parenthical we should always be appending ", (keep existing compat)". For some reason we're not? The workflow for this repo isn't overriding it either?

😕

Do the actions logs show anything useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants