Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream and then tar heap snapshot #48

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jun 28, 2024

To avoid building the heap snapshot in-memory and therefore possibly OOMing if the process is under memory pressure.

@d-netto d-netto force-pushed the dcn-stream-and-tar-heap-snapshot branch 2 times, most recently from b5ebcda to e2a173c Compare June 28, 2024 15:03
@d-netto d-netto requested review from NHDaly and Drvi June 28, 2024 15:06
@d-netto d-netto force-pushed the dcn-stream-and-tar-heap-snapshot branch 5 times, most recently from d497f7b to 7695c22 Compare June 28, 2024 20:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (ffd6913) to head (2bf8076).
Report is 4 commits behind head on main.

Files Patch % Lines
src/ProfileEndpoints.jl 71.42% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ffd6913) and HEAD (2bf8076). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ffd6913) HEAD (2bf8076)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #48       +/-   ##
===========================================
- Coverage   90.00%   78.87%   -11.13%     
===========================================
  Files           1        1               
  Lines         190      232       +42     
===========================================
+ Hits          171      183       +12     
- Misses         19       49       +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-netto d-netto force-pushed the dcn-stream-and-tar-heap-snapshot branch from 7695c22 to 2bf8076 Compare July 3, 2024 00:03
@d-netto
Copy link
Member Author

d-netto commented Jul 3, 2024

Bump?

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ LGTM.

Is this already covered by a test? Can the test just confirm that the file path ends in .tar or something like that?

@d-netto d-netto closed this Jul 18, 2024
@d-netto d-netto reopened this Jul 18, 2024
@d-netto
Copy link
Member Author

d-netto commented Jul 18, 2024

(Sorry, I probably closed by accident)

@d-netto
Copy link
Member Author

d-netto commented Jul 19, 2024

Can the test just confirm that the file path ends in .tar or something like that?

Thanks for the suggestion. Added a test to test the extension.

@d-netto d-netto merged commit 205054c into main Jul 19, 2024
9 of 12 checks passed
@d-netto d-netto deleted the dcn-stream-and-tar-heap-snapshot branch July 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants