Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Cell #3

Open
cortner opened this issue Mar 22, 2018 · 3 comments
Open

Automatic Cell #3

cortner opened this issue Mar 22, 2018 · 3 comments

Comments

@cortner
Copy link
Member

cortner commented Mar 22, 2018

consider redefining the cell in terms of the extent of X when NOT PBC

@cortner
Copy link
Member Author

cortner commented May 30, 2018

more generally, make it a default to ignore the cell dimension in the non-PBC direction and always project to the cell in the PBC directions. + document this clearly. That way there is no more ambiguity how the positions are treated. See also #6

@cortner
Copy link
Member Author

cortner commented May 30, 2018

While I am revisiting the meaning of the cell variable, should also double-check and test what happens when the determinant is negative. Probably it makes no difference, but who knows?

@cortner
Copy link
Member Author

cortner commented Jun 2, 2018

this is implemented by still needs to be documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant