Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mass #100

Closed
cortner opened this issue May 18, 2024 · 2 comments
Closed

Introduce mass #100

cortner opened this issue May 18, 2024 · 2 comments

Comments

@cortner
Copy link
Member

cortner commented May 18, 2024

I think the default mass of a particle should be mass and not atomic_mass.

First, this does not create any ambiguities: The prefix atomic_ is to emphasize it is the mass of an atom. If the particle of which we are getting the mass is an atom then that information is already encoded in the type of the particle object. In other words, mass(x::Atom) already encodes all the information, whereas atomic_mass(x::Atom) duplicates it.

Secondly, it will generalize the terminology to other particles that are not necessarily atoms.

One could introduce mass side by side with atomic_mass or it could entirely replace atomic_mass.

@mfherbst
Copy link
Member

Personally I don't care so much about the name.

@cortner
Copy link
Member Author

cortner commented Jul 1, 2024

maybe to be part of the next breaking version discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants