Make switch_direction consistent
#639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbaran
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
===========================================
- Coverage 98.87% 40.49% -58.39%
===========================================
Files 106 106
Lines 10206 10081 -125
===========================================
- Hits 10091 4082 -6009
- Misses 115 5999 +5884
... and 80 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I think this should be more or less ready. @olivierverdier , do you think this solves the issue? I was trying to make the default close to what we currently have but now you can express all four options and switch just the left/right or forward/backward part of the action. Rotation and translation actions are all forward now. |
kellertuer
approved these changes
Jul 7, 2023
|
It does solve the issue, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a solution that will resolve #637 by introducing four different action directions instead of just two.
TODO: