Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a template and plugin for PkgBenchmarks #261

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Conversation

anandijain
Copy link
Contributor

I think some folks may find this useful.

Feel free to close if unnecessary.

Also I think this might conflict with the Configurations.jl PR.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #261 (ecf91cf) into master (16b8c23) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   92.59%   92.08%   -0.52%     
==========================================
  Files          19       20       +1     
  Lines         540      543       +3     
==========================================
  Hits          500      500              
- Misses         40       43       +3     
Impacted Files Coverage Δ
src/PkgTemplates.jl 100.00% <ø> (ø)
src/plugin.jl 98.07% <ø> (ø)
src/plugins/benchmarks.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b8c23...ecf91cf. Read the comment docs.

@nickrobinson251 nickrobinson251 added the Plugin Idea A proposal for a feature that can be accomplished with a plugin label Jan 6, 2022
@gdalle
Copy link
Collaborator

gdalle commented Jul 31, 2023

bumping this, seems like a good idea

@gdalle
Copy link
Collaborator

gdalle commented Jul 31, 2023

solves #86

@gdalle
Copy link
Collaborator

gdalle commented Oct 10, 2023

I'd like to take this PR over the finish line by adding tests. @christopher-dG @DilumAluthge or @vchuravy can someone add me to the org so that I'm allowed to push to this branch?

@vchuravy
Copy link
Member

MIght be better to recommend PkgBenchmarks.jl?

@gdalle
Copy link
Collaborator

gdalle commented Oct 11, 2023

Yes that's actually what is done in the code but I can't change the PR title

@vchuravy vchuravy changed the title add a template and plugin for BenchmarkTools add a template and plugin for PkgBenchmarks Oct 11, 2023
@vchuravy
Copy link
Member

I'd like to take this PR over the finish line

Probably best to just open a new PR and cherry-pick the original change.

@gdalle
Copy link
Collaborator

gdalle commented Oct 11, 2023

Probably best to just open a new PR and cherry-pick the original change.

Also possible of course, I just wanted @anandijain to be recognized as a contributor, which won't happen if I copy-paste their code in a new PR :)

@gdalle
Copy link
Collaborator

gdalle commented Oct 11, 2023

there are other PRs I could also push further, that's why I'd love access to the repo but I understand if you prefer not to hand it out

@vchuravy
Copy link
Member

I only have access due to being a org-admin; I will defer to @oxinabox she seems to be the most active developer here.

@oxinabox
Copy link
Collaborator

I thought you already had merge permissions @gdalle .
I was kinda wondering why you were not merging a few PRs that you had reviewed. 😂
Go here to accept your invite.

Using git cherrypick will keep attributions of commits to original author, BTW.

@gdalle
Copy link
Collaborator

gdalle commented Dec 15, 2023

TODO:

  • create benchmarks.jl file
  • create environment files
  • set up optional CI with BenchmarkCI.jl
  • add tests?

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7b5a51) 92.91% compared to head (81c56c7) 92.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   92.91%   92.94%   +0.02%     
==========================================
  Files          23       24       +1     
  Lines         734      737       +3     
==========================================
+ Hits          682      685       +3     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Collaborator

gdalle commented Dec 18, 2023

Merging even though the to-do list is incomplete, because this is functional as is

@gdalle gdalle merged commit dea191b into JuliaCI:master Dec 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugin Idea A proposal for a feature that can be accomplished with a plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants