Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize sqrt and cbrt #379

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Specialize sqrt and cbrt #379

merged 6 commits into from
Aug 29, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 22, 2024

After this,

julia> F = Fill(4, 4, 4)
4×4 Fill{Int64}, with entries equal to 4

julia> sqrt(F)
4×4 Fill{Float64}, with entries equal to 1.0

julia> sqrt(F)^2 == F
true

julia> F = Fill(-8, 8, 8)
8×8 Fill{Int64}, with entries equal to -8

julia> cbrt(F)
8×8 Fill{Float64}, with entries equal to -0.5

julia> cbrt(F)^3 == F
true

cbrt doesn't work with complex values because which the definition isn't obvious (JuliaLang/julia#36534).

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (9868632) to head (2df5678).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   99.90%   99.91%           
=======================================
  Files           8        8           
  Lines        1110     1136   +26     
=======================================
+ Hits         1109     1135   +26     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Aug 29, 2024

Good to merge? I'm not sure why the codecov job is stuck

@dlfivefifty dlfivefifty merged commit 90ef3ce into master Aug 29, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants