Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some error message diagnostics #962

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix some error message diagnostics #962

merged 3 commits into from
Mar 15, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Mar 12, 2024

The diagnostics currently fail in some cases because of access to non-existing fields of a machine when machine (attached to some Node) is actually nothing.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.01%. Comparing base (f7ef4fe) to head (542d81f).
Report is 1 commits behind head on dev.

Files Patch % Lines
src/composition/learning_networks/nodes.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #962      +/-   ##
==========================================
- Coverage   88.02%   88.01%   -0.02%     
==========================================
  Files          28       28              
  Lines        2548     2554       +6     
==========================================
+ Hits         2243     2248       +5     
- Misses        305      306       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom merged commit 44ca101 into dev Mar 15, 2024
5 checks passed
@ablaom ablaom deleted the diagnostics branch March 15, 2024 03:08
@ablaom ablaom mentioned this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant