Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with serialization of nested models when component model overload save/restore #960

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Feb 29, 2024

This PR resolves #927.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (831abfa) to head (f7ef4fe).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #960      +/-   ##
==========================================
+ Coverage   88.00%   88.02%   +0.02%     
==========================================
  Files          28       28              
  Lines        2542     2548       +6     
==========================================
+ Hits         2237     2243       +6     
  Misses        305      305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Member Author

ablaom commented Feb 29, 2024

Waiting for offline MLJ integration tests:

  • Passed

@ablaom ablaom merged commit b23bbd6 into dev Mar 1, 2024
5 checks passed
@ablaom ablaom deleted the nested-serialization branch March 1, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialized Composite Model Fails with XGBoost
1 participant