changed devDependencies to dependencies #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows me (and hopefully others as well) to use this plugin in conjunction with [main-bower-files](https://github.com/ck86/main-bower-files) without having to mannually override the dependencies of this component to ensure that everything is properly pulled into the build. Currently, I have to include the following to make my build work ```json { ... "overrides": { "jr-crop" : { "dependencies":{ "ionic" : "*" } } } ```
|
If I have it right, main-bower-files pulls all dependencies from the bower.json files, but not the devDependencies? Blueimp and ionic are only used for the examples, therefore they are in devDependencies. You should be able to include them, and your preferred version number yourself in your own bower.json. |
|
The one other thing that main-bower-files does is ensure that dependencies of the component are loaded/listed before component itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows me (and hopefully others as well) to use this plugin in conjunction with main-bower-files without having to mannually override the dependencies of this component to ensure that everything is properly pulled into the build.
Currently, I have to include the following to make my build work
{ ... "overrides": { "jr-crop" : { "dependencies":{ "ionic" : "*", "blueimp-canvas-to-blob":"*" } } }