Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Note-entry - move to previous chord #604

Closed
worldwideweary opened this issue Aug 30, 2024 · 5 comments · Fixed by #605 · May be fixed by #666
Closed

Enhancement: Note-entry - move to previous chord #604

worldwideweary opened this issue Aug 30, 2024 · 5 comments · Fixed by #605 · May be fixed by #666

Comments

@worldwideweary
Copy link

worldwideweary commented Aug 30, 2024

Keyboard user observation:

  1. Note Entry - Switch to voice two when there isn't a voice two rest but there is in the previous measure
  2. User can't move left to select voice-2 rests. Probably "by design" but I don't like it:
  3. Option: User can use Prev-Element (alt-left) to do so but can't do so in note entry so exit note entry, alt-left a few times, then
  4. Back to note entry again. Either that. or move to the left measure and switch voices and then move forward to the designated area:
Navigation.webm

Seems kinda lame and imo would be better to allow this:

Navig2.mp4
@Jojo-Schmitz
Copy link
Owner

Is this a regression vs 3.6? Or something that works better in Mu4?

@worldwideweary
Copy link
Author

worldwideweary commented Aug 31, 2024

Neither, it's just an improvement for note entry in "3.7". trying to make sense of some of my older personal build changes because there's like 200+ commits with many bound up for multiple purposes, often for improved (from my perspective) note entry and navigation with the keyboard. This would be one of the little ones

@Jojo-Schmitz
Copy link
Owner

So you plan for a PR on this?

@worldwideweary
Copy link
Author

Yeah I'll try it out actually right now and you can test it out sometime later or whatever

@worldwideweary worldwideweary changed the title Note Entry Observation - Previous Chord Improvement: Note-entry - move to previous chord Aug 31, 2024
@worldwideweary worldwideweary changed the title Improvement: Note-entry - move to previous chord Enhancement: Note-entry - move to previous chord Sep 1, 2024
@worldwideweary
Copy link
Author

Oh, found a problem/regression with #605 because it uses nextChordRest(track, true); which doesn't consider grace notes. Grace notes are then skipped while in note entry mode using "Previous chord" :-/

Have a fix....
Found the problem when realizing that likewise you can't be in "Voice-2" with no CR and then use "Previous Measure" command... doesn't do anything (it's always been that way in 3.6.2 etc). I'll get a PR to also allow that and fix the problem
a little later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment