implement receive_data_tcp #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| pub(crate) const MAX_NINA_PARAM_LENGTH: usize = 4096; | ||
| pub(crate) const MAX_NINA_RESPONSE_LENGTH: usize = 4096; | ||
|
|
||
| pub type ResponseData = [u8; MAX_NINA_RESPONSE_LENGTH]; |
Check warning
Code scanning / clippy
missing documentation for a type alias
| ParamLengthSize::TwoByte => self.get_two_byte_response_length().unwrap(), | ||
| }; | ||
|
|
||
| for i in 0..response_length { |
Check warning
Code scanning / clippy
the loop variable `i` is only used to index `response_bytes`
jhodapp
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
describe the intent of your changes here
GitHub Issue: link your GitHub issue here
Changes
Testing Strategy
describe how you or someone else can test and verify the changes
Concerns
describe any concerns that might be worth mentioning or discussing