chore(client): move everything in root but electron to the client subfolder #1945
Conversation
daniellacosse
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
daniellacosse
changed the title
daniellacosse
force-pushed
the
daniellacosse/contain_cordova_3
branch
from
12629b4
to
1276015
Compare
| import {ShadowsocksSessionConfig} from '../www/app/tunnel'; | ||
| import {TunnelStatus} from '../www/app/tunnel'; | ||
| import {ErrorCode, fromErrorCode, UnexpectedPluginError} from '../www/model/errors'; | ||
| import {pathToEmbeddedBinary} from '../../client/src/infrastructure/electron/app_paths'; |
There was a problem hiding this comment.
Not for this PR, but infrastructure should move out of the client eventually.
There was a problem hiding this comment.
Yes - so far I have five cleanup steps to do after this is merged:
- move src/electron into client
- remove client/src
- collapse all the output/build folders into one that's in the root (non-trivial with cordova, but I have an idea)
- create an infrastructure package and move src/build and client/src/infrastructure into it
- move outline/device into client/tun2socks and rename it to client/backend
Anything I'm forgetting?
| return [navigator.language]; | ||
| } | ||
|
|
||
| window.OutlineI18n = { |
There was a problem hiding this comment.
I'm replacing the archived https://github.com/Jigsaw-Code/outline-i18n
It's only used here, it's not in the manager: https://github.com/search?q=repo%3AJigsaw-Code%2Foutline-apps%20outline-i18n&type=code
There was a problem hiding this comment.
If it's only used here, why to you need to mess with window?
Just call the getBestMatchingLanguage method directly.
| return [navigator.language]; | ||
| } | ||
|
|
||
| window.OutlineI18n = { |
There was a problem hiding this comment.
If it's only used here, why to you need to mess with window?
Just call the getBestMatchingLanguage method directly.
Co-authored-by: Vinicius Fortuna <[email protected]>
There was a problem hiding this comment.
I see some icons being added. What happened?
There was a problem hiding this comment.
We had to revert the icons in order to upload iOS, which caused a bunch of conflicts in this PR, so I had to resolve that.
I was able to successfully move the client into its own subfolder:
codeql is complaining because it's being triggered on the moved files. should I ignore it?