From 009a3fac3c1919fa057ad4529e3b6d4dedd793e2 Mon Sep 17 00:00:00 2001 From: Sander Bruens Date: Mon, 18 Mar 2024 14:15:19 -0400 Subject: [PATCH 1/2] chore(www): add `meaning` attribute to messages with mismatched number of placeholders --- resources/original_messages.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/resources/original_messages.json b/resources/original_messages.json index 429aee6ceb..8ada1686a7 100644 --- a/resources/original_messages.json +++ b/resources/original_messages.json @@ -77,6 +77,7 @@ }, "contact_view_exit_connection": { "description": "Message shown to users who are trying to contact support about an unsupported issue.", + "meaning": "Message shown to users who are trying to contact support about an unsupported issue.", "message": "The Outline team is not able to assist with connecting to a server. Please try the troubleshooting steps listed $START_OF_LINK$here$END_OF_LINK$ and then contact the person who gave you the access key to troubleshoot this issue.", "placeholders": { "END_OF_LINK": { @@ -89,6 +90,7 @@ }, "contact_view_exit_no_server": { "description": "Message shown to users who are trying to contact support about an unsupported issue.", + "meaning": "Message shown to users who are trying to contact support about an unsupported issue.", "message": "The Outline team does not distribute free or paid access keys. $START_OF_LINK$Learn more about how to get an access key.$END_OF_LINK$", "placeholders": { "END_OF_LINK": { From b73023a3048c3ab0af82da5fea4d189af012d5df Mon Sep 17 00:00:00 2001 From: sbruens Date: Wed, 20 Mar 2024 10:11:50 -0400 Subject: [PATCH 2/2] Use a more specific meaning. --- resources/original_messages.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/original_messages.json b/resources/original_messages.json index 8ada1686a7..2f1b9cd72c 100644 --- a/resources/original_messages.json +++ b/resources/original_messages.json @@ -77,7 +77,7 @@ }, "contact_view_exit_connection": { "description": "Message shown to users who are trying to contact support about an unsupported issue.", - "meaning": "Message shown to users who are trying to contact support about an unsupported issue.", + "meaning": "MsgID-20240319-UpdateWhenPlaceHolderChanged", "message": "The Outline team is not able to assist with connecting to a server. Please try the troubleshooting steps listed $START_OF_LINK$here$END_OF_LINK$ and then contact the person who gave you the access key to troubleshoot this issue.", "placeholders": { "END_OF_LINK": { @@ -90,7 +90,7 @@ }, "contact_view_exit_no_server": { "description": "Message shown to users who are trying to contact support about an unsupported issue.", - "meaning": "Message shown to users who are trying to contact support about an unsupported issue.", + "meaning": "MsgID-20240319-UpdateWhenPlaceHolderChanged", "message": "The Outline team does not distribute free or paid access keys. $START_OF_LINK$Learn more about how to get an access key.$END_OF_LINK$", "placeholders": { "END_OF_LINK": {