Fix #315: JTest uses a flawed RNG setup #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and caller name based seed inside constructor (Fixes #315)
RaiqaRasool
force-pushed
the
rasool_issue315SeedRNGFix
branch
from
67719cc
to
002aeae
Compare
nathanwbrei
reviewed
Aug 22, 2024
| @@ -26,8 +26,9 @@ class GroupedEventProcessor : public JEventProcessor { | |||
|
|
|||
| void Process(const std::shared_ptr<const JEvent>& event) override { | |||
|
|
|||
| std::unique_ptr<JBenchUtils> bench_utils = std::make_unique<JBenchUtils>(event->GetEventNumber(), NAME_OF_THIS); | |||
There was a problem hiding this comment.
The constructor for JBenchUtils might be expensive, so I'd consider adding a method to reset the seed rather than recreating the object on every event. If you make bench_utils be a member variable, you can construct it exactly once and then reset the seed on every event. Also, you don't need the unique_ptr here because ownership stays with the component and there's no inheritance hierarchy to watch out for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses issue #315 by replacing
JPerfUtilswithJBenchUtils, transitioning from standalone functions to a class-based format. The seed for the RNG is now set inside theJBenchUtilsconstructor using the event number and caller name passed to the constructor.Changes:
JPerfUtilswithJBenchUtils.JBenchUtilsis now a class that encapsulates the RNG.JBenchUtilsconstructor, ensuring it is set based on the event number and caller name, enhancing reproducibility and eliminating the need for the previous thread-local workaround.Benefits:
JPerfUtils.Related Issue:
Testing: