-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Advanced features grouping #3563
Conversation
shared/domain/src/main/java/com/ivy/domain/features/FeatureGroup.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesUiState.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesUiState.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesUiState.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
screen/features/src/main/java/com/ivy/features/FeaturesViewModel.kt
Outdated
Show resolved
Hide resolved
Great work, thanks! I think both preferences in the Other group refer to the new transaction/payment screen, you might want to consider labeling them that way, |
@shamim-emon let's also reduce a bit the spacing above the section headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also attach a screen recording to see how it looks like and if toggling works as expected?
screen/features/src/main/java/com/ivy/features/FeaturesScreen.kt
Outdated
Show resolved
Hide resolved
document_6316313672981419953.online-video-cutter.com.mp4 |
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.