Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Advanced features grouping #3563

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Sep 26, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've included advanced feature grouping.

photo_6316313673437659157_y

Risk factors

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 26, 2024
@nvllz
Copy link
Contributor

nvllz commented Sep 26, 2024

Great work, thanks! I think both preferences in the Other group refer to the new transaction/payment screen, you might want to consider labeling them that way,

@ILIYANGERMANOV
Copy link
Collaborator

@shamim-emon let's also reduce a bit the spacing above the section headers

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also attach a screen recording to see how it looks like and if toggling works as expected?

@shamim-emon
Copy link
Member Author

Can you also attach a screen recording to see how it looks like and if toggling works as expected?
@ILIYANGERMANOV here's a recording!

document_6316313672981419953.online-video-cutter.com.mp4

@ILIYANGERMANOV ILIYANGERMANOV merged commit 6ba6690 into Ivy-Apps:main Sep 26, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3559 branch September 26, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Advanced features grouping
3 participants