Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of asserts #362

Open
lehins opened this issue Jan 31, 2023 · 1 comment
Open

Usage of asserts #362

lehins opened this issue Jan 31, 2023 · 1 comment

Comments

@lehins
Copy link
Collaborator

lehins commented Jan 31, 2023

There are a few places in KES implementation where Control.Exception.assert is being used. This has no affect since asserts will never get triggered, because they are removed by the compiler, unless compiled with either -O0 or -fno-ignore-asserts, which is never the case in this repo.

So, we need figure out whats the purpose of those asserts and either remove them in favor of some other mode of failure or make them count with a cabal flag or something. A good example on how latter can be achieved is in the consensus repo.

@tdammers
Copy link
Contributor

tdammers commented Feb 1, 2023

This is kind of how asserts are supposed to work, but IMO it's a good idea to just enable them (-fno-ignore-asserts) - at the very least for testing, but I think it won't hurt to turn them on in production, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants