Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scratchsig doesn't work with echo #16

Open
mrsrec opened this issue Dec 17, 2023 · 5 comments
Open

scratchsig doesn't work with echo #16

mrsrec opened this issue Dec 17, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@mrsrec
Copy link

mrsrec commented Dec 17, 2023

Making a talk page post and signing it with scratchsig won't trigger an Echo notification.

Echo works by "expanding" the wikitext including templates and such into the actual formatting that would be rendered into HTML, and scanning that for an appropriate link. A link to your userpage, talk page, or contributions page is required for a notification to be sent.

Unfortunately, because scratchsig isn't a template or module, and is an actual tag, that's as far as the "expanding" process would go--because that tag spits out HTML, even if it does so via wikitext. This means that in its current state, scratchsig won't work with Echo.

@jacob-g has created a short-term mitigation for this issue by hacking the Echo core to look for the scratchsig tags, but this isn't a good long-term solution.

Other ideas suggested include:

  • Using Echo's custom notification system to make our own sendout for talk page messages
  • Asking Echo developers to change how signatures are looked for
  • Changing scratchsig to only handle the profile pictures and not the wikitext (since wikitext could just be done directly)
    ** This was suggested by @Kenny2github though I expanded on this in further detail
  • Removing scratchsig entirely
    ** The main argument for this would be that only the English wiki has ever used it, so removing it would make it more like the other wikis

This issue is a good place to track the long-term Echo issue

@mrsrec
Copy link
Author

mrsrec commented Dec 17, 2023

My idea based on Kenny2github's idea: https://discord.com/channels/328938947717890058/764646854343655464/1185315307112374382


OK, thinking about this some more I have some new ideas.

PFPs can work via user ID, and they can be put in "in-plae" at time of editing, this saves recursive calls.

For legacy tag, archive pages can be edited. This means that history diffs will break, but maybe there can be a tag there that doesn't use lookups or something

So something like:

<scratchpfp id="661830" />

And a magic tag like {{subst:GETSCRATCHUSERID#mrsrec}} which would be replaced with 661830 when the page saves.

Then, the default signature is:

<scratchpfp id="{{subst:GETSCRATCHUSERID#{{subst:REVISIONUSER}}" /> [[User:{{subst:REVISIONUSER}}|{{subst:REVISIONUSER}}]] ([[User_talk:{{subst:REVISIONUSER}}|talk]])
Thoughts?

@Kenny2github
Copy link
Member

My opinion is that you should consider the original <scratchsig> tag immutable. The user-facing behavior of that must not change - we are not going to go back and edit archives. Either we get that tag working with Echo (ideally) or we keep <scratchsig> as is and find some other solution.

@Kenny2github Kenny2github added the bug Something isn't working label Dec 17, 2023
@mrsrec
Copy link
Author

mrsrec commented Dec 17, 2023

My opinion is that you should consider the original <scratchsig> tag immutable. The user-facing behavior of that must not change - we are not going to go back and edit archives. Either we get that tag working with Echo (ideally) or we keep <scratchsig> as is and find some other solution.

Hmmm.. OK, but this confuses me, because changing how signatures work and moving avatars to a different tag was your idea in the first place. Did I misunderstand you or did you change your mind? Either way please let me know, thank you.

@Kenny2github
Copy link
Member

My idea was to add a different tag for the new kind of signature and use that going forward. In all cases my intent was for <scratchsig> to either work or be kept in perpetuity for backwards compatibility.

@mrsrec
Copy link
Author

mrsrec commented Dec 18, 2023

OK. That's what I meant as well. The external calls could probably go away but other than that there's no need to change it. These are proposals for new tags and usage from now on--old edits wouldn't need to be changed since only new ones would generate notifications.

Which of them does everyone think is best?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants