Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type checking callback in CallResponder.apiCall #395

Open
nptravis opened this issue Jun 16, 2023 · 0 comments
Open

type checking callback in CallResponder.apiCall #395

nptravis opened this issue Jun 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nptravis
Copy link

nptravis commented Jun 16, 2023

Version
1.5.3

Module (core, cmpapi, cli, stub, or testing)
cmpapi

Describe with reproduction steps – What is the expected behavior?
We have been logging many errors due to the callback in CallResponder.apiCall not being a function. I assume this is one of our vendors misusing the cmpapi by passing in an invlaid callback. I assume this could also be happening to others, therefore would like to propose this fix. I would rather have the more descriptive throw new Error('invalid callback function'); handle this.

Here is the PR:
#394

@nptravis nptravis added the bug Something isn't working label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant