Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENO V3 - add shapeFrom on all Expression #902

Open
1 task
laurentC35 opened this issue Feb 7, 2024 · 1 comment
Open
1 task

ENO V3 - add shapeFrom on all Expression #902

laurentC35 opened this issue Feb 7, 2024 · 1 comment
Labels
enhancement Would be nice but non prioritary

Comments

@laurentC35
Copy link
Contributor

laurentC35 commented Feb 7, 2024

In order to increase performance with caching in Lunatic.
We need something like shapeFrom (like in calculated variables)

See this conversation: InseeFr/Lunatic#871 (comment)

ToDo:

  • add shapeFrom for expression in model for Lunatic output
@laurentC35 laurentC35 added the enhancement Would be nice but non prioritary label Feb 7, 2024
@nsenave
Copy link
Contributor

nsenave commented Feb 7, 2024

Does it concern only expressions that are in Luantic labels of type "VTL", or also those of type "VTL|MD"?

Labels of type VTL in json Lunatic:

  • calculated variables expression
  • filters expression
  • controls expression
  • main loop min/max expressions
  • linked loop iterations expression
  • dynamic table min/max expressions
  • pairwise xAxis/yAxis expressions

Labels of type VTL|MD in json Lunatic:

  • labels in sequence, subsequence and question, declarations, controls (error message), options in unique/mutliple choice questions

➡️ Where should be put the "shapeFrom" property?

Currently it only exists in calculated variable objects (that are defined at an iteration level):

    {
      "variableType": "CALCULATED",
      "name": "FOO",
      "expression": {
        "value": "<VTL expression>",
        "type": "VTL"
      },
      "bindingDependencies": [
        "VAR1", "VAR2"
      ],
      "shapeFrom": "SOME_ARRAY_VARIABLE",
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Would be nice but non prioritary
Projects
None yet
Development

No branches or pull requests

2 participants