Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payara 6: Embargo selection fails from Dataverse page, works from file page. #9773

Closed
kcondon opened this issue Aug 11, 2023 · 1 comment · Fixed by #9857
Closed

Payara 6: Embargo selection fails from Dataverse page, works from file page. #9773

kcondon opened this issue Aug 11, 2023 · 1 comment · Fixed by #9857
Assignees
Labels
Size: 10 A percentage of a sprint. 7 hours.
Milestone

Comments

@kcondon
Copy link
Contributor

kcondon commented Aug 11, 2023

Found while testing Payara 6 branch: #9685
Selecting embargo from the dataset page, either from the individual file kebab or the edit files menu, results in a popup that says selected files are already published and cannot be embargoed, along with a stack trace. The popup and stack trace appear to be the same in both cases.
Screen Shot 2023-08-11 at 9 31 55 AM
embargo_fail_datasetpg_editfiles.txt
embargo_fail_datasetpg_file_kebab.txt

Selecting embargo from the files page, edit files button, works but shows the same stack trace in the logs
embargo_success_filepg_editfile.txt

So, it seems like the failure is initializing the popup due to null, but for some reason the error handling from the file page allows it to proceed anyway but from the dataset page it seems to go to an incorrect, perhaps default error?

@scolapasta scolapasta added this to the 6.0 milestone Aug 11, 2023
@cmbz cmbz added the Size: 10 A percentage of a sprint. 7 hours. label Aug 16, 2023
@sekmiller sekmiller self-assigned this Aug 17, 2023
@sekmiller sekmiller removed their assignment Aug 18, 2023
@scolapasta
Copy link
Contributor

scolapasta commented Aug 29, 2023

One thing I noticed is that if you then click the embargo a 2nd time, it does show a differently "incorrect" popup. but this also happens if you click on a file that is already published - that is it shows the some part of the popup that would be correct for the "previous" file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
4 participants