IQSS/10705: Refactor permission filter query in indexing #10706
+65
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
commented
Jul 19, 2024
| // ----------------------------------- | ||
| // PERMISSION FILTER QUERY | ||
| // ----------------------------------- | ||
| String permissionFilterQuery = this.getPermissionFilterQuery(dataverseRequest, solrQuery, onlyDatatRelatedToMe, addFacets); |
There was a problem hiding this comment.
the dataverse param was never used in getPermissionFilterQuery - that must have been dropped at some point.
qqmyers
commented
Jul 19, 2024
|
|
||
| logger.fine("Groups: " + groupString); | ||
| String permissionQuery = buildPermissionFilterQuery(avoidJoin, groupString); | ||
| logger.fine("Permission Query: " + permissionQuery); |
There was a problem hiding this comment.
This and the query from the existing code line 1203 should be the same in all cases, whether the avoidJoin flag is set or not.
qqmyers
added
Size: 3
sekmiller
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: See issue. This is a refactor that should be easier to maintain and slightly more efficient.
Which issue(s) this PR closes:
Closes #10705
Special notes for your reviewer: FWIW: I wouldn't have done this if QDR didn't need to get the string listing the groups for reuse, which meant I had to pull apart the code generating the query itself from just getting that group list.
Suggestions on how to test this: Nominally this PR should produce no change/users should still see the same things in search, correct for their permissions. The easiest way to test may be to just set FINE logging on the SearchServiceBean and verify that the queries produced in both the current and new code are the same.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: