Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in download estimate function changed for Guestbook-at-request functionality #10095

Closed
qqmyers opened this issue Nov 3, 2023 · 0 comments · Fixed by #10096
Closed

Bug in download estimate function changed for Guestbook-at-request functionality #10095

qqmyers opened this issue Nov 3, 2023 · 0 comments · Fixed by #10096
Labels
Type: Bug a defect
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Nov 3, 2023

What steps does it take to reproduce the issue?
Seen at QDR: An error in the estimateGuestBookResponseTableSize function added to postgres was introduced in #9599. The new code to estimate what fraction of guestbook table entries relate to downloads and not to access requests incorrectly give the type bigint to a number that is a fraction. See

ELSE 1 - (SELECT (most_common_freqs::text::text[])[array_position(most_common_vals::text::text[], 'AccessRequest')]::bigint
. Changing the type to float resolves the issue.

  • When does this issue occur?
    When the number of guestbook entries is large enough and guestbook-at-request functionality has been enabled.

  • Which page(s) does it occurs on?
    Homepage showing the download count

  • What happens?
    Causes a 500 error

Which version of Dataverse are you using?
develop

PR to follow

@qqmyers qqmyers added the Type: Bug a defect label Nov 3, 2023
@pdurbin pdurbin added this to the 6.1 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants