Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access of an app outiside its allowed IP address range causes Internal Server Error #89

Open
Ajayneethikannan opened this issue Jan 11, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers urgent

Comments

@Ajayneethikannan
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.
500 error when the user's IP address is not in allowed IP rings.

To Reproduce
Steps to reproduce the behavior:
Access an app outside it's allowed IP rings.

Expected behavior
A clear and concise description of what you expected to happen.
404 Not Found

Screenshots
If applicable, add screenshots to help explain your problem.

Operating System:

  • OS: Linux
  • Browser: Chrome

Additional context
Add any other context about the problem here.

Want to take up?
Are you interested in and capable of tackling this issue? [yes|no]

@Ajayneethikannan
Copy link
Member Author

Ajayneethikannan commented Jan 11, 2020

Reason: ip_address_rings is a dictionary but used as a list in the case when not in allowed_ip_rings
in omniport/omniport/middleware/ip_address_rings.py

@Ajayneethikannan Ajayneethikannan added bug Something isn't working good first issue Good for newcomers urgent labels Jan 11, 2020
@pradumangoyal
Copy link
Member

I think #97 has resolved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers urgent
Projects
None yet
Development

No branches or pull requests

2 participants