Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove server-side HTTP GET requests #90

Open
gcschmit opened this issue Dec 27, 2023 · 1 comment
Open

remove server-side HTTP GET requests #90

gcschmit opened this issue Dec 27, 2023 · 1 comment

Comments

@gcschmit
Copy link
Contributor

There a few points in the server-side code that get data from the sever by specifying an endpoint. For example:

let manualSchedule = await axios.get(`http://localhost:${process.env.PORT || 8080}/schedule/matches`).then(res=>res.data) // temp fix

This should be replace with a simple function invocation. If the endpoint needs to be available to clients, decompose the behavior into a function that can also be invoked from the router.

@Allybe
Copy link
Contributor

Allybe commented Jan 8, 2024

I think this would greatly benefit SPOT, really would help organize the code base! This should probably done with the use of a "main manager" maybe? A manager that holds other managers inside it so that the code is nice and neat, would require a ton of rewriting of existing code though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants