Apply @:haxe.warning rules to cached warnings too #11775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kLabz
commented
Sep 17, 2024
kLabz
commented
- will need to add tests for this at some point
Simn
reviewed
Sep 17, 2024
| @@ -22,11 +22,9 @@ let warned_positions = Hashtbl.create 0 | |||
| let warn_deprecation dctx s p_usage = | |||
| let pkey p = (p.pfile,p.pmin) in | |||
| if not (Hashtbl.mem warned_positions (pkey p_usage)) then begin | |||
| Hashtbl.add warned_positions (pkey p_usage) (s,p_usage); | |||
| if not (is_diagnostics dctx.com) then begin | |||
There was a problem hiding this comment.
Hmm, there's a chance that this was here for a reason, though I can't immediately tell why.
There was a problem hiding this comment.
Yeah, I'll try to figure out why it was there. I had to remove it, though, otherwise the module could be cached without the warning if cached from diagnostics.. :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.