Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Int128 + its numeral literal suffix #11750

Open
wants to merge 100 commits into
base: development
Choose a base branch
from

Conversation

SomeGuyWhoLovesCoding
Copy link

Everything in the pure haxe version is done but the issue is that Int128.mul(a, b) doesn't multiply properly with the value bigger than 1.8e19 which means the number will overflow. So, I was wondering if any of you could please fix that issue.

@EyeDaleHim
Copy link

I'm not sure if this is the right place to ask for help, the Issues tab might be more sufficient.

@Simn
Copy link
Member

Simn commented Aug 24, 2024

Actually I prefer a PR here because it's easier to reason about the code and see the failing tests, so I think this is a good initiative.

@SomeGuyWhoLovesCoding
Copy link
Author

How come 14 tests failed?

@EyeDaleHim
Copy link

How come 14 tests failed?

That's what the details tab are for, perhaps you can click on them :P

@SomeGuyWhoLovesCoding
Copy link
Author

This is an error from linux build 4.08.1:

   - |   [...]
 126 | }
Type Int64Helper refined from class Int128Helper```

@skial skial mentioned this pull request Aug 24, 2024
1 task
@SomeGuyWhoLovesCoding
Copy link
Author

Now I'm just waiting for this pr to get merged

@LeonGamerPS1
Copy link

balls

@SomeGuyWhoLovesCoding
Copy link
Author

balls

Ok

@skial skial mentioned this pull request Sep 5, 2024
1 task
This adds the ability to construct a `haxe.io.Bytes` out of part of the file's bytes in the most efficient way possible.
@SomeGuyWhoLovesCoding SomeGuyWhoLovesCoding changed the title Implement Int128 + its numeral literal suffix Upgrade File.getBytes to have starting position and length + Implement Int128 + its numeral literal suffix Sep 9, 2024
@SomeGuyWhoLovesCoding SomeGuyWhoLovesCoding changed the title Upgrade File.getBytes to have starting position and length + Implement Int128 + its numeral literal suffix Implement Int128 + its numeral literal suffix Sep 11, 2024
@SomeGuyWhoLovesCoding
Copy link
Author

Ignore the commits adter the hrr 717 mention. It was an accident and I didn't mean to do so.

@SomeGuyWhoLovesCoding
Copy link
Author

SomeGuyWhoLovesCoding commented Sep 12, 2024

100 commits. Oh boy. I wasted the 15 of them lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants