[hl] Ignore WANT_READ/WANT_WRITE errors when the socket is known to b… #11655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apprentice-Alchemist
force-pushed
the
bugfix/hl-ssl
branch
from
b9279fc
to
5e72596
Compare
kLabz
pushed a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e blocking.
Sometimes mbedtls returns WANT_READ/WANT_WRITE errors (the case I encountered while working on HaxeFoundation/hashlink#681 seems to be due to session tickets).
These should be interpreted as "retry when more data is known to be available", but there is no good way to express that in the current api when the socket is blocking other than returning zero.
Together with HaxeFoundation/hashlink#681 this should be enough to get rid of the HL+macOS failures in #11638.