Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
inherit
@:unreflective on generic classes
- Loading branch information
68c95dfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Simn I'm adding this to 4.3_bugfix, which doesn't have
AutoBuild(norKeepSub) there.Should I add all 3, or only
Unreflective? (given that the other two were added in a much bigger change (#11376))68c95dfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh, I'm not sure about
AutoBuildbecause that might cause behavioral differences. I'd dig up why this was added to see if it's a worthwhile bugfix for 4.3.68c95dfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added there d2fa580
68c95dfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd skip it, #5536 is a narrow (and old) issue and the involvement of #11376 makes me rather nervous.
68c95dfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
What about 1200c5c / #6500 for
@:keepSub? Seems like the same arguments apply there68c95dfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like with DCE the worst case is that something ends up being kept that shouldn't be kept, which isn't that terrible. So I'd include that one.