SSL bugfixes. #681
Merged
SSL bugfixes. #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
pushed a commit
to tobil4sk/neko
that referenced
this pull request
Jul 2, 2024
In mbedtls 3.6 TLS 1.3 support is turned on by default which uses PSA crypto See HaxeFoundation/hashlink#681
tobil4sk
pushed a commit
to tobil4sk/neko
that referenced
this pull request
Jul 2, 2024
In mbedtls 3.6 TLS 1.3 support is turned on by default which uses PSA crypto See HaxeFoundation/hashlink#681
tobil4sk
pushed a commit
to tobil4sk/neko
that referenced
this pull request
Jul 3, 2024
In mbedtls 3.6 TLS 1.3 support is turned on by default which uses PSA crypto See HaxeFoundation/hashlink#681
Simn
pushed a commit
to HaxeFoundation/neko
that referenced
this pull request
Jul 3, 2024
* [ssl] Add mbedtls 3 compatibility This means that mbedtls 3 is supported for dynamic builds * [ci] Use mbedtls3 for dynamic mac build * [cmake] Update to mbedtls 3.6 for static builds Use MBEDTLS_USER_CONFIG_FILE instead of patching the sources. * [ssl] Initialize PSA crypto when it is present. In mbedtls 3.6 TLS 1.3 support is turned on by default which uses PSA crypto See HaxeFoundation/hashlink#681 * [ci] Build on ubuntu bionic instead of xenial Xenial went EoL in 2021, and we cannot build new mbedtls versions on it. * [ssl] Fix mbedtls compilation errors on windows * [ssl] Link bcrypt on windows * [ssl] Define mbedtls config file when compiling ssl.c --------- Co-authored-by: Apprentice-Alchemist <[email protected]>
|
@yuxiaomao Could you check if this works for you guys? If so I'd like to see this merged because there are some related open Haxe issues. |
|
It's very Mac specific so I can't really understand it :x. But as I can't find any problem in the code and build on both CI / local machines seems fine, let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecTrustCopyAnchorCertificatesto get root certs on macOS instead of the deprecated keychain apis.The partially fixes the macOS HTTPS failures encountered in HaxeFoundation/haxe#11638.