Remove Matrix Math from default shader

[NeeEoo]

Since the current matrix math can be simplified to a simple multiply

[Geokureli]

For future PRs, please edit your settings.json's formatting to include:
"editor.formatOnSaveMode": "modifications"
and add the following to your hxformat.json

"indentation":{
    "trailingWhitespace": true
}

[Geokureli]

Where is openfl_ColorMultiplierv set? I tried all the following and found no difference with the old or new code:

sprite.shader.colorMultiplier.value = [1.0, 0.0, 1.0, 1.0];
sprite.color = 0xFFff00ff;
sprite.setColorTransform(1, 0, 1, 1);

[NeeEoo]

Its handled in openfl and drawquaditem

Its the same usage as before

[Geokureli]

is there a way I can verify that whatever purpose openfl_ColorMultiplierv served before, is still working after this change?

[NeeEoo]

Removing the * openfl_ColorMultiplierv would just make it not react to .color

[Geokureli]

it doesn't react to .color, now, before and after this change

[NeeEoo]

On flxsprite?

[NeeEoo]

This commit is supposed to be a simplification of the math. To replicate the same behavior.

[SrtHero278]

is there a way I can verify that whatever purpose openfl_ColorMultiplierv served before, is still working after this change?

matrix multiplication actually.
this originally did

r, 0, 0, 0
0, g, 0, 0
0, 0, b, 0
0, 0, 0, a
(rgba is equal to xyzw, its swizzling)

matrices multiplied with a vector behave like this.
since all of the other values are 0, it just becomes [x * m11, y * m22, z * m33, w * m44]
and m11 is r, m22 is g, m33 is b, and m44 is a, the exact same values.
the matrix is just nothing but a middleman.

[Geokureli]

I still don't know what purpose openfl_ColorMultiplierv has because I can't seem to write any code that effects this property. Until I understand what purpose it has I can't approve any changes to its behavior

On flxsprite?

Yes

[NeeEoo]

var hue = 0.0;

override public function update(elapsed:Float):Void
{
	super.update(elapsed);
	sprite.color = FlxColor.fromHSB((hue += elapsed * 180) % 360, 0.5, 1.0);
}

Before my change:
https://github.com/user-attachments/assets/1ae37d92-32e9-4fc0-a94b-0bcce7ae1905

After my change:
https://github.com/user-attachments/assets/b3bb82d7-25b3-4cbb-a5a6-95a88a5b1380

[MaybeMaru]

sprite.color =

0xFFffffff	0xFFff0000

[nebulazorua]

The intent is for the same behaviour but now its faster
the matrix code was an unnecessary step in the shader and just served to be a bit slower

If you notice no visual change pre and post change with changing sprite.color, that means its working as intended

[Geokureli]

I see the issue, for some reason defining the shader with a fragment sorce causes sprite.color to not work for some reason. This was the state I quickly made, to test this change, because I thought this was something that effected sprites with custom shaders on it:

package states;

class ShaderColorTestState extends flixel.FlxState
{
	override public function create()
	{
		super.create();
		
		final sprite = new flixel.FlxSprite().makeGraphic(100, 100);
		sprite.shader = new SimpleShader();
		sprite.color = 0xFFff00ff;
		add(sprite);
	}
}

class SimpleShader extends flixel.system.FlxAssets.FlxShader
{
	@:glFragmentSource('
		#pragma header
		
		void main()
		{
			gl_FragColor = texture2D(bitmap, openfl_TextureCoordv);
		}
	')
	public function new()
	{
		super();
	}
}

the above resulted in a white square, when I was expecting a magenta square, if I comment out the glFragmentSource, it seems to work, which is odd, but that's unrelated to this.

Thanks!

[Geokureli]

made a new issue of the behavior specified above: #3246