Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fnf 6 #3186

Draft
wants to merge 20 commits into
base: release6
Choose a base branch
from
Draft

Fnf 6 #3186

wants to merge 20 commits into from

Conversation

Geokureli
Copy link
Member

@Geokureli Geokureli commented Jun 14, 2024

@EliteMasterEric This is the only remaining change between https://github.com/FunkinCrew/flixel/tree/dev-6.0.0 and release6. I can't find out what this change does, can you clarify, what does adding a true arg to @:glVertexSource and @:glFragmentSource do?

also you can update your dev-6.0.0 branch with https://github.com/FunkinCrew/flixel/compare/dev-6.0.0...Geokureli:fnf-6?expand=1

@EliteMasterEric
Copy link
Contributor

Adding a true argument to the vertex source and fragment source annotations does nothing on the official build of OpenFL.

However, it DOES do something on my shader rewrite branch of OpenFL (see openfl/openfl#2715).

That branch implements the glVersion parameter to shaders, allowing you to use other GLSL versions (such as 120 on MacOS and 300 es on web).

However, this has a problem; the annotations on any parent classes were written for GLSL 100, and therefore need to be rewritten to support the new GLSL version. Thankfully, this is relatively trivial, as you can simply perform a find/replace and no special syntax changes are needed, but these changes should only be done on the internal annotations and not the user-provided shader annotations. Thus, I added an optional argument to the annotation to tell the macro system when to rewrite the shader source.

@Geokureli Geokureli marked this pull request as draft June 14, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants