add ability to name instance in config so that discord notifications … #489
+26
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are named for people running multiple instances of fairgame
config/amazon_config.template_json
Outdated
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "instance_name": "Fairgame1", | |||
There was a problem hiding this comment.
Why not have the default be Fairgame? Would the user have to edit this config file for each instance? What happens if you run two instances with the same name?
There was a problem hiding this comment.
Default instance name changed to Fairgame.
User does not have to edit the default if they don't want to. But if running multiple instances then they can update it to help keep control of instances.
Nothing will break if you run two instances with the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are named for people running multiple instances of fairgame.
This way users can know which instance a notification came from.
To configure: Change the default name of "Fairgame1" in amazon_config.json to whatever you want.