Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mIRC formatting (colours etc.) not stripped from IRC messages #145

Open
alanbriolat opened this issue Feb 2, 2019 · 0 comments
Open

mIRC formatting (colours etc.) not stripped from IRC messages #145

alanbriolat opened this issue Feb 2, 2019 · 0 comments

Comments

@alanbriolat
Copy link
Member

alanbriolat commented Feb 2, 2019

Example, repr() vs. str():

(D:csbot.raw_log) >>> ':[email protected] PRIVMSG #hacksoc :<\x034atc520\x0f> Oh, oh dear'
(I:csbot.pretty_log) [#hacksoc] <hackbot> <4atc520> Oh, oh dear

It's unclear whether this is a bug or a feature request. In some cases we might want to preserve such things, in other cases they might interfere with other logic. I'd suggest exposing the message content both before and after stripping (the latter being the default, i.e. requiring no code change elsewhere), and allow plugins to make their own decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant