Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Can't +1 Own Chats, Interesting Results #2441

Closed
deilann opened this issue Jan 17, 2014 · 14 comments
Closed

Testing Can't +1 Own Chats, Interesting Results #2441

deilann opened this issue Jan 17, 2014 · 14 comments

Comments

@deilann
Copy link
Contributor

deilann commented Jan 17, 2014

Attempting to +1 your own chats now gives you the lovely message. However, it freezes up my browser then redirects me back to tasks, rather than leaving me in the Tavern.

@colegleason
Copy link
Contributor

@deilann: Do you still experience this? I can't seem to reproduce it.

@deilann
Copy link
Contributor Author

deilann commented Jan 18, 2014

Yes. I attempt to +1, get a hang up, and then it redirects me to the tasks
page. Happens in Chrome on my laptop, Chrome on my Android tablet, and
Puffin on my Android tablet.

On Fri, Jan 17, 2014 at 9:29 PM, Cole Gleason [email protected]:

@deilann https://github.com/deilann: Do you still experience this? I
can't seem to reproduce it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2441#issuecomment-32675149
.

@deilann
Copy link
Contributor Author

deilann commented Jan 18, 2014

(For the record, I just tested it in Chrome on my laptop.)

On Fri, Jan 17, 2014 at 9:44 PM, Ryan [email protected] wrote:

Yes. I attempt to +1, get a hang up, and then it redirects me to the tasks
page. Happens in Chrome on my laptop, Chrome on my Android tablet, and
Puffin on my Android tablet.

On Fri, Jan 17, 2014 at 9:29 PM, Cole Gleason [email protected]:

@deilann https://github.com/deilann: Do you still experience this? I
can't seem to reproduce it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2441#issuecomment-32675149
.

@colegleason
Copy link
Contributor

When you get a chance, could you please do the following to help me debug?

  1. Right click on the page and click "Inspect Element" to open the developer tools.
  2. Click the tab called "Console".
  3. Right click the console and check "Preserve Log upon Navigation"
  4. Try to +1 your chat message.
  5. Copy any text that appears in the console window here.

@deilann
Copy link
Contributor Author

deilann commented Jan 18, 2014

Strangely, not getting anything there. Further notes: If I let the
notification expire and do not attempt to close it, I do not get a redirect.

Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means
dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to
the actual 'dpi' of a screen. In media query expression:
(-webkit-min-device-pixel-ratio: 1.5), (min-resolution: 144dpi)
tweet_button.1389999802.html:1https://platform.twitter.com/widgets/tweet_button.1389999802.html
Given URL is not allowed by the Application configuration.: One or more of
the given URLs is not allowed by the App's settings. It must match the
Website URL or Canvas URL, or the domain must be a subdomain of one of the
App's domains.
body.scrollLeft is deprecated in strict mode. Please use
'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft' only
if in quirks mode.
body.scrollTop is deprecated in strict mode. Please use
'documentElement.scrollTop' if in strict mode and 'body.scrollTop' only if
in quirks mode.

On Fri, Jan 17, 2014 at 9:53 PM, Cole Gleason [email protected]:

When you get a chance, could you please do the following to help me debug?

  1. Right click on the page and click "Inspect Element" to open the
    developer tools.
  2. Click the tab called "Console".
  3. Right click the console and check "Preserve Log upon Navigation"
  4. Try to +1 your chat message.
  5. Copy any text that appears in the console window here.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2441#issuecomment-32675445
.

@colegleason
Copy link
Contributor

Ah, I wasn't trying to close it. I am now getting that problem.

On Sat, Jan 18, 2014 at 12:09 AM, deilann [email protected] wrote:

Strangely, not getting anything there. Further notes: If I let the
notification expire and do not attempt to close it, I do not get a
redirect.

Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means
dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to
the actual 'dpi' of a screen. In media query expression:
(-webkit-min-device-pixel-ratio: 1.5), (min-resolution: 144dpi)
tweet_button.1389999802.html:1<
https://platform.twitter.com/widgets/tweet_button.1389999802.html>
Given URL is not allowed by the Application configuration.: One or more of
the given URLs is not allowed by the App's settings. It must match the
Website URL or Canvas URL, or the domain must be a subdomain of one of the
App's domains.
body.scrollLeft is deprecated in strict mode. Please use
'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft' only
if in quirks mode.
body.scrollTop is deprecated in strict mode. Please use
'documentElement.scrollTop' if in strict mode and 'body.scrollTop' only if
in quirks mode.

On Fri, Jan 17, 2014 at 9:53 PM, Cole Gleason [email protected]:

When you get a chance, could you please do the following to help me
debug?

  1. Right click on the page and click "Inspect Element" to open the
    developer tools.
  2. Click the tab called "Console".
  3. Right click the console and check "Preserve Log upon Navigation"
  4. Try to +1 your chat message.
  5. Copy any text that appears in the console window here.


Reply to this email directly or view it on GitHub<
https://github.com/HabitRPG/habitrpg/issues/2441#issuecomment-32675445>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2441#issuecomment-32675644
.

Cole Gleason

Student, University of Illinois at Urbana-Champaign
Email: [email protected]
Website: colegleason.com

@deilann
Copy link
Contributor Author

deilann commented Jan 18, 2014

Further testing: other notification popups act similarly.

Fed pets to test it, despite not having the right food, oh well, and
closing that popup took me to /tasks as well.

On Sat, Jan 18, 2014 at 1:05 AM, Cole Gleason [email protected]:

Ah, I wasn't trying to close it. I am now getting that problem.

On Sat, Jan 18, 2014 at 12:09 AM, deilann [email protected]
wrote:

Strangely, not getting anything there. Further notes: If I let the
notification expire and do not attempt to close it, I do not get a
redirect.

Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means
dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to
the actual 'dpi' of a screen. In media query expression:
(-webkit-min-device-pixel-ratio: 1.5), (min-resolution: 144dpi)
tweet_button.1389999802.html:1<
https://platform.twitter.com/widgets/tweet_button.1389999802.html>
Given URL is not allowed by the Application configuration.: One or more
of
the given URLs is not allowed by the App's settings. It must match the
Website URL or Canvas URL, or the domain must be a subdomain of one of
the
App's domains.
body.scrollLeft is deprecated in strict mode. Please use
'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft'
only
if in quirks mode.
body.scrollTop is deprecated in strict mode. Please use
'documentElement.scrollTop' if in strict mode and 'body.scrollTop' only
if
in quirks mode.

On Fri, Jan 17, 2014 at 9:53 PM, Cole Gleason [email protected]:

When you get a chance, could you please do the following to help me
debug?

  1. Right click on the page and click "Inspect Element" to open the
    developer tools.
  2. Click the tab called "Console".
  3. Right click the console and check "Preserve Log upon Navigation"
  4. Try to +1 your chat message.
  5. Copy any text that appears in the console window here.


Reply to this email directly or view it on GitHub<
https://github.com/HabitRPG/habitrpg/issues/2441#issuecomment-32675445>
.


Reply to this email directly or view it on GitHub<
https://github.com/HabitRPG/habitrpg/issues/2441#issuecomment-32675644>
.

Cole Gleason

Student, University of Illinois at Urbana-Champaign
Email: [email protected]
Website: colegleason.com


Reply to this email directly or view it on GitHubhttps://github.com//issues/2441#issuecomment-32677763
.

@colegleason
Copy link
Contributor

Here is the issue (in bootstrap-growl): https://github.com/ifightcrime/bootstrap-growl/blob/master/jquery.bootstrap-growl.js#L16

We will want to modify that package to use window.location or something instead of #.

@deilann
Copy link
Contributor Author

deilann commented Jan 18, 2014

A quick fix would be to set allow_dismiss: false

On Sat, Jan 18, 2014 at 1:10 AM, Cole Gleason [email protected]:

Here is the issue (in bootstrap-growl):
https://github.com/ifightcrime/bootstrap-growl/blob/master/jquery.bootstrap-growl.js#L16

We will want to modify that package to use window.location or something
instead of #.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2441#issuecomment-32677833
.

@colegleason
Copy link
Contributor

Sure, but let's see if we can't fix it real fast. Issue submitted here: longlostnick/bootstrap-growl#40

I can also fork if we need to, but I would rather not.

@deilann
Copy link
Contributor Author

deilann commented Feb 11, 2014

@colegleason This is driving me crazy. :c My default response when I see and read a notif is to close it.

@negue
Copy link
Member

negue commented Dec 5, 2014

Can't reproduce, @deilann does this issue still exist?

@crookedneighbor
Copy link
Contributor

@deilann I can't reproduce it either. Going to close it now. Re-open it if you're still experiencing it.

@deilann
Copy link
Contributor Author

deilann commented Jan 31, 2015

I think we use a different notification system now
On Jan 31, 2015 9:34 AM, "Blade Barringer" [email protected] wrote:

Closed #2441 #2441.


Reply to this email directly or view it on GitHub
#2441 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants