Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we should only keep around uvdata objects with valid vis_units #352

Open
aewallwi opened this issue Jan 1, 2022 · 0 comments
Open

we should only keep around uvdata objects with valid vis_units #352

aewallwi opened this issue Jan 1, 2022 · 0 comments

Comments

@aewallwi
Copy link
Collaborator

aewallwi commented Jan 1, 2022 •
edited
Loading

mK are not a valid visibility unit for a UVData object (valid units are either Jy or K sr, see https://github.com/RadioAstronomySoftwareGroup/pyuvdata/blob/9ab7332cabd065aac2ebf0931c0ed7dc02cabc89/pyuvdata/uvdata/uvdata.py#L84), but in hera_pspec, we like to carry around uvdata objects with units of mK which are technically not valid units for this data type.

We should organized hera_pspec normalization in a way that does not require carrying around invalid uvdata objects.
@aewallwi aewallwi changed the title we should stop relying on uvdata objects with non-valid vis_units we should only keep around uvdata objects with valid vis_units Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aewallwi